[PATCH] D82860: Port ObjCMTAction to new option parsing system

[Daniel Grumberg via Phabricator via llvm-commits]

dang marked an inline comment as done.
dang added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:328-331
+  HelpText<"Enable migration to modern ObjC literals">,
+  MarshallingInfoFlag<"FrontendOpts.ObjCMTAction", "0", "unsigned">, Normalizer<"normalizeFlagToValue<unsigned>">,
+  ValueMerger<"MERGE_VALUE_MASK">, ValueExtractor<"EXTRACT_VALUE_MASK">,
+  NormalizerCookie<"FrontendOptions::ObjCMT_Literals">;
----------------
If this kind of combination of normalizer, value merger and extractor happen again, I will make a mixin that helps set this up. Or do you reckon it is worth doing it now for readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82860/new/

https://reviews.llvm.org/D82860