[PATCH] D81906: [CodeGen] Expand float operand for STRICT_FSETCC/STRICT_FSETCCS

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand requested changes to this revision.
uweigand added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:1766
   NewRHS = SDValue();   // LHS is the result, not a compare.
 }
 
----------------
This isn't handling chains correctly.  The function needs to collect the output chains of the four separate SetCC operations and return an output chain to the caller.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:1900
+    ReplaceValueWith(SDValue(N, 0), NewLHS);
+    ReplaceValueWith(SDValue(N, 1), Chain);
+    return SDValue();
----------------
See above; this needs to use the output Chain.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81906/new/

https://reviews.llvm.org/D81906