[PATCH] D82435: [DWARFYAML][debug_gnu_*] Add the missing context `IsGNUStyle`. NFC.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 30 01:35:11 PDT 2020
jhenderson added inline comments.
================
Comment at: llvm/unittests/ObjectYAML/DWARFYAMLTest.cpp:77
+ auto SectionsOrErr = DWARFYAML::emitDebugSections(Yaml);
+ EXPECT_THAT_EXPECTED(SectionsOrErr, Succeeded());
+}
----------------
I think in the two passing cases, it would be good to check the value of the `Descriptor` field in the `Entries`. Ideally, I'd also test the other fields in tha YAML, but that might be outside the scope of this change, and better deferred to a later change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82435/new/
https://reviews.llvm.org/D82435
More information about the llvm-commits
mailing list