[PATCH] D82826: [X86] support .nops directive
Jian Cai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 29 18:34:39 PDT 2020
jcai19 added a comment.
In D82826#2121595 <https://reviews.llvm.org/D82826#2121595>, @craig.topper wrote:
> Would it be possible to emit a new Fragment type and leverage the existing NOP emission code in X86AsmBackend.cpp. The code here appears to be copied from X86MCInstLower. Which would mean we would now have 3 places that do almost the same thing.
Thanks for the suggestion. Did not know there was a second copy already. Will try to reuse the code from X86AsmBackend.cpp.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82826/new/
https://reviews.llvm.org/D82826
More information about the llvm-commits
mailing list