[PATCH] D79794: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction.

[Bill Wendling via Phabricator via llvm-commits]

void added a comment.

In D79794#2121018 <https://reviews.llvm.org/D79794#2121018>, @nickdesaulniers wrote:

> The only other concern I have is whether we have enough test coverage of the scheduling boundary changes?  (Does removing the added checks there cause any existing or new test from the change to file?  If not, seems like a lack of test coverage.) In the case of `PostRASchedulerList`, that implies a MIR test (writing MIR tests isn't something I'd wish on my worst enemy though).


The reason it wasn't failing before was because INLINEASM_BR was a terminator, and the boundary check automatically caught it. The existing test, llvm/test/CodeGen/X86/callbr-asm-outputs.ll, did fail though. So at least we're covered there.

Don't get me wrong, I'm always up for adding more tests, but I think this change is okay in that regard. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79794/new/

https://reviews.llvm.org/D79794