[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis
    Johannes Doerfert via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Jun 29 08:36:48 PDT 2020
    
    
  
jdoerfert added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:932
       case Attribute::NoCfCheck:
+      case Attribute::NoUndef:
         break;
----------------
nikic wrote:
> Not familiar with this code, but based on the placement of other similar attributes like nonnull, this should probably be in the first list.
Technically, it should not matter because this is not a function attribute. That said, the first list makes logically more sense. I would even prefer three lists, OK to propagate, not OK, and assertion.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81678/new/
https://reviews.llvm.org/D81678
    
    
More information about the llvm-commits
mailing list