[PATCH] D81788: [OpenMPOpt] ICV Tracking

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 marked an inline comment as done.
sstefan1 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:889
+        if (!pair.first->comesBefore(I))
+          continue;
+
----------------
jdoerfert wrote:
> sstefan1 wrote:
> > jdoerfert wrote:
> > > Make both conditionals early exits
> > I guess this makes sense now, but as we improve this, more conditionals will be added and it won't make sense to exit early.
> It depends. Having 3 early exists is, for me at least, nicer than one big condition.
Just to make sure we're on the same page here. I'm not saying there will be one big condition. Rather, right now there is the case when both instructions are in the same BB. In the future we also want to cover the case when they are not. Does that make sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81788/new/

https://reviews.llvm.org/D81788