[PATCH] D82536: [AVR] Use correct relocation for function pointers in globals

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 29 15:18:25 PDT 2020


aykevl added a comment.

I experimented a bit more but I really can't find a way to tell the difference between undefined functions and undefined globals. Assuming one or the other will still be incorrect in some cases.

Maybe the situation can be improved from the current situation by only creating the `R_AVR_16_PM` relocation for defined functions? That part is easy, and fixes this bug in at least some cases (while not making it worse in other cases). Fixing this bug for undefined functions may require changes somewhere else in LLVM, and might be a bit too much for me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82536/new/

https://reviews.llvm.org/D82536





More information about the llvm-commits mailing list