[PATCH] D82786: [llvm-ar] Unsupport test on FreeBSD

Ed Maste via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 29 15:18:25 PDT 2020


emaste added a comment.

In D82786#2120605 <https://reviews.llvm.org/D82786#2120605>, @kevans wrote:

> Sorry- the review is fine as-is. There is some nuance here, but it is better to just mark this unsupported for now (as you've done) and we (FreeBSD) can revisit later when all supported versions do not allow reading dirfds.


That said we should put a comment by the `UNSUPPORTED` so someone who comes across this in the future might remove it again when no longer needed. E.g. make the comment "Unsupported on FreeBSD as FreeBSD 12 and earlier allow reading directories by default."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82786/new/

https://reviews.llvm.org/D82786





More information about the llvm-commits mailing list