[PATCH] D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation

[Scott Constable via Phabricator via llvm-commits]

sconstab added a comment.

Other than the inline comments, LGTM.



================
Comment at: llvm/lib/Target/X86/X86TargetMachine.cpp:493
   if (getOptLevel() != CodeGenOpt::None)
     addPass(createX86LoadValueInjectionLoadHardeningPass());
 }
----------------
Please add a comment here to clarify that if `getOptLevel() == CodeGenOpt::None` then SESES will provide mitigation when `LVILoadHardening` is enabled.


================
Comment at: llvm/test/CodeGen/X86/lvi-hardening-loads.ll:37
+; X64-NOOPT-NEXT:      lfence
+; X64-NOOPT-NEXT:      lfence
 ; X64-NOOPT-NEXT:      movl $0, -{{[0-9]+}}(%rsp)
----------------
zbrid wrote:
> Sorry, this is totally weird and I'll look into why this happens. 
Has this been fixed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82037/new/

https://reviews.llvm.org/D82037