[PATCH] D82322: [ASan][MSan] Remove EmptyAsm and set the CallInst to nomerge to avoid from merging.

Mon Jun 29 12:28:56 PDT 2020

zequanwu added a comment.

In D82322#2120525 <https://reviews.llvm.org/D82322#2120525>, @uweigand wrote:

> In D82322#2120497 <https://reviews.llvm.org/D82322#2120497>, @zequanwu wrote:
>
> > In D82322#2119815 <https://reviews.llvm.org/D82322#2119815>, @uweigand wrote:
> >
> > > It looks like this broke the s390x build bots, since then I'm seeing a lot of ASan and MSan errors:
> > >  http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33485
> >
> >
> > It seems like all those tests failed because the second `CHECK` should match output line 4 but missing the line number at the end.
> >  Since the patch passed tests in all other build bots, I wonder if it's because the build bot config is flaky.
>
>
> @iii had a look and it appears the problem is that this patch https://reviews.llvm.org/D79537 didn't add support on SystemZ, so we get wrong line numbers when merging happens.  Ilya is working on a patch.

Thanks for the fix

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82322/new/

https://reviews.llvm.org/D82322