[PATCH] D82708: [MachineLICM] NFC - make safety of moving explicitly for IsLoopInvariantInst
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 29 11:54:21 PDT 2020
efriedma added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:219
- bool IsLoopInvariantInst(MachineInstr &I);
+ bool IsLoopInvariantInst(MachineInstr &I, bool &IsSafeToMove);
----------------
Instead of returning the IsSafeToMove bit, maybe it would be simpler to add an input parameter "AllowRematOperands"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82708/new/
https://reviews.llvm.org/D82708
More information about the llvm-commits
mailing list