[PATCH] D80838: [llvm-ar] Add more tests for errors in opening archives

Mon Jun 29 11:21:39 PDT 2020

kevans added a comment.

In D80838#2119256 <https://reviews.llvm.org/D80838#2119256>, @jhenderson wrote:

> In D80838#2119065 <https://reviews.llvm.org/D80838#2119065>, @sameerarora101 wrote:
>
> > Seems like FreeBSD allows for reading directories. In that case would the issue be resolved in case I add the following line to the test:
> >  `# UNSUPPORTED: system-freebsd`
> >
> > or perhaps
> >
> > `# XFAIL: system-freebsd`
> >
> > I'll update the test accordingly then. Thanks a lot!
>
>
> `# UNSUPPORTED` would be the right approach - I don't think the FreeBSD behaviour is something we're likely to "fix" either in FreeBSD or llvm-ar so that the test will pass. I don't know if `freebsd` is a "system" that can easily be identified though.

I mentioned this in the other review, but for what it's worth- we have in-fact managed to change this behavior for FreeBSD 13.0-CURRENT, and I expect to make the change for FreeBSD 12.2 if it doesn't cause too much friction. UNSUPPORTED still seems correct, since you'll have a mixed bag of pass/fail based on exact FreeBSD version (and filesystem, even) in play.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80838/new/

https://reviews.llvm.org/D80838