[PATCH] D82773: [ARM][MVE] Tail-predication: clean-up removing unused code

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 29 08:04:50 PDT 2020


SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: samparker, dmgreen.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls.
Herald added a project: LLVM.

After the rewrite of this pass (D79175 <https://reviews.llvm.org/D79175>) I missed one thing: the inserted VCTP intrinsic can be cloned to exit blocks if there are instructions present in it that perform the same operation. However, it turns out that for handling reductions, see D75533 <https://reviews.llvm.org/D75533>, it's actually easier not not to have the VCTP in exit blocks. If the exit block was cloned, we rematerialized the trip count in the exit blocks, because that made other dead-code removal easier. But our dead-code removal got more powerful, so I don't think this is still needed and therefore this also removes RematerializeIterCount.


https://reviews.llvm.org/D82773

Files:
  llvm/lib/Target/ARM/MVETailPredication.cpp
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/vector-reduce-mve-tail.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82773.274128.patch
Type: text/x-patch
Size: 7772 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200629/e3924a51/attachment-0001.bin>


More information about the llvm-commits mailing list