[PATCH] D82754: [lit] Prevent hang when lit sees non-ASCII characters

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

Please add a test to lit's test suite, perhaps something like `llvm/utils/lit/tests/Inputs/shtest-shell/stdout-encoding.txt`.

Thanks for working on this.



================
Comment at: llvm/utils/lit/lit/display.py:89
                     pass
-                out = out.decode(encoding=sys.stdout.encoding)
+                out = out.decode(encoding=sys.stdout.encoding, errors="ignore")
             print(out)
----------------
Please add a comment documenting the platform where this problem can be seen.  Include the python version.  If people try to simplify this subtle passage of code later, perhaps to abandon python 2 support, such comments should prove helpful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82754/new/

https://reviews.llvm.org/D82754