[PATCH] D80713: [AMDGPU] Support disassembly for AMDGPU kernel descriptors

[Ronak Chauhan via Phabricator via llvm-commits]

rochauha marked 2 inline comments as done.
rochauha added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:1476
+  // The failed region is from 0 to this new value of Size. We do this because
+  // most directives in the kernel descriptor affect a single or very few bits.
+  switch (Cursor.tell()) {
----------------
rochauha wrote:
> jhenderson wrote:
> > Bits or bytes?
> Bits.
> 
> If there is a bit that is wrong in a particular chunk of bytes, we consider that the entire chunk of bytes is invalid. We then update the `Size` value.
> 
> Further, we say that the first `Size` bytes in a symbol are invalid. Error handling in llvm-objdump will print these bytes using `.byte` directive. And then we fall back to decoding the remaining bytes in the symbol as instructions.
We do this because most directives in the kernel descriptor affect single or a very few bits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80713/new/

https://reviews.llvm.org/D80713