[PATCH] D82566: [CodeMoverUtils] Make specific analysis dependent checks optional

[rithik sharma via Phabricator via llvm-commits]

RithikSharma marked an inline comment as done.
RithikSharma added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:319
+  if (!DT)
+    return false;
 
----------------
Whitney wrote:
> Actually if DI or PDT or DI, either one is nullptr, than this function never return true, so why not just check that in the beginning.
I understood your point. Say we don't have DT, PDT or DI then instead of returning false should we return true/false based on our best knowledge? If a client don't have DT, PDT and DI then it may be expecting at least some checks (which may or may not be of any real use)? Also, when we will add more analysis (example MSSA) then would it make more sense to return true/false based on whatever checks/analysis we have with us and not conservatively returning false?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82566/new/

https://reviews.llvm.org/D82566