[PATCH] D82454: [ADT] Add Bitfield utilities - design #3

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 29 05:54:16 PDT 2020


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/ADT/Bitfields.h:21
+///
+/// The methods provided in this file ensures precise control over the
+/// layout/storage as well as protection against out of range values.
----------------
ensure


================
Comment at: llvm/include/llvm/ADT/Bitfields.h:193
+/// Internally though we only manipulate integer with well defined and
+/// consistent semantic, this excludes typed enums and `bool` that are replaced
+/// with their unsigned counterparts. The correct type is restored in the public
----------------
semantics


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82454/new/

https://reviews.llvm.org/D82454





More information about the llvm-commits mailing list