[PATCH] D80838: [llvm-ar] Add more tests for errors in opening archives

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 29 01:02:24 PDT 2020


jhenderson added a comment.

In D80838#2119065 <https://reviews.llvm.org/D80838#2119065>, @sameerarora101 wrote:

> Seems like FreeBSD allows for reading directories. In that case would the issue be resolved in case I add the following line to the test:
>  `# UNSUPPORTED: system-freebsd`
>
> or perhaps
>
> `# XFAIL: system-freebsd`
>
> I'll update the test accordingly then. Thanks a lot!


`# UNSUPPORTED` would be the right approach - I don't think the FreeBSD behaviour is something we're likely to "fix" either in FreeBSD or llvm-ar so that the test will pass. I don't know if `freebsd` is a "system" that can easily be identified though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80838/new/

https://reviews.llvm.org/D80838





More information about the llvm-commits mailing list