[PATCH] D82361: [PowerPC] Only make copies of registers on stack in variadic function when va_start is called

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 28 19:48:57 PDT 2020


steven.zhang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:4295
   // the start of the first vararg value... for expansion of llvm.va_start.
-  if (isVarArg) {
+  if (isVarArg && MFI.hasVAStart()) {
     int Depth = ArgOffset;
----------------
Please add some necessary comments here to prove that, we don't need these stores if there is no va_start.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82361/new/

https://reviews.llvm.org/D82361





More information about the llvm-commits mailing list