[PATCH] D82735: [PM] Fix new PM to perform SpeculativeExecution as in old PM
Daniil Fukalov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 28 18:13:13 PDT 2020
dfukalov created this revision.
dfukalov added a reviewer: chandlerc.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
Old PM runs SpeculativeExecutionPass for targets that have divergent branches.
It uses `createSpeculativeExecutionIfHasBranchDivergencePass` that creates
the pass with `OnlyIfDivergentTarget=true`, whereas new PM just created the
pass with default `OnlyIfDivergentTarget=fase` so it unexpectedly runs and
causes buildbot test fails.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D82735
Files:
llvm/lib/Passes/PassBuilder.cpp
Index: llvm/lib/Passes/PassBuilder.cpp
===================================================================
--- llvm/lib/Passes/PassBuilder.cpp
+++ llvm/lib/Passes/PassBuilder.cpp
@@ -584,7 +584,7 @@
}
// Speculative execution if the target has divergent branches; otherwise nop.
- FPM.addPass(SpeculativeExecutionPass());
+ FPM.addPass(SpeculativeExecutionPass(/* OnlyIfDivergentTarget =*/true));
// Optimize based on known information about branches, and cleanup afterward.
FPM.addPass(JumpThreadingPass());
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82735.273985.patch
Type: text/x-patch
Size: 527 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200629/8b67c54c/attachment-0001.bin>
More information about the llvm-commits
mailing list