[PATCH] D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC)

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 28 08:39:59 PDT 2020


lattner added a comment.

This is looking directionally great, please ping me after hubert.reinterpretcast's comments are reviewed and resolved.  Thanks!



================
Comment at: llvm/docs/CodingStandards.rst:1657
+  if (auto *D = dyn_cast<FunctionDecl>(D)) {
+    if(shouldProcess(D))
+      handleVarDecl(D);
----------------
MaskRay wrote:
> Add a space after `if`
and after the for.  Also, I'd recommend using size_t instead of 'int', and != instead of <.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82594/new/

https://reviews.llvm.org/D82594





More information about the llvm-commits mailing list