[PATCH] D82712: Improve stack object printing. NFC.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFrameInfo.cpp:213
 void MachineFrameInfo::print(const MachineFunction &MF, raw_ostream &OS) const{
-  if (Objects.empty()) return;
-
+  OS << "MF name: " << MF.getName() << "\n";
+  if (Objects.empty()) {
----------------
This is noise


================
Comment at: llvm/lib/CodeGen/MachineFrameInfo.cpp:215
+  if (Objects.empty()) {
+    OS << "No stack objects.\n";
+    return;
----------------
This is kind of noise too


================
Comment at: llvm/lib/CodeGen/MachineFrameInfo.cpp:236
     }
+    OS << "isSplitSplot=" << static_cast<bool>(SO.isSpillSlot) << ", ";
     if (SO.Size == 0)
----------------
It would be more consistent to add an is spill after the rest of the info


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82712/new/

https://reviews.llvm.org/D82712