[PATCH] D82719: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays

[Hamilton Tobon-Mosquera via Phabricator via llvm-commits]

hamax97 marked 2 inline comments as done.
hamax97 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:558
+
+  unsigned getValuesInOfflArrays(MemoryTransfer &MT) {
+    auto *RuntimeCall = MT.RuntimeCall;
----------------
sstefan1 wrote:
> Is this supposed to return anything else other that `EXIT_FAILURE` or `EXIT_SUCCESS`? If not, why not just use `bool`?
> 
> Same for `getValuesInOfflArray()`?
I thought this would be more understandable. Also, it allows to return some other code and probably make a different decision. But I don't mind changing it


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:919
+  /// Used to get the MemorySSA analysis of a specified function.
+  MemorySSAGetter MSSAGetter;
+
----------------
sstefan1 wrote:
> I think you should be able to use `getAnalysisResultForFunction()` from `OMPInformationCache` since analysis getters are available in Attributor's `InformationCache`. (see Attributor.h)
Ohh thanks. I'll use that then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82719/new/

https://reviews.llvm.org/D82719