[PATCH] D82719: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:558
+
+  unsigned getValuesInOfflArrays(MemoryTransfer &MT) {
+    auto *RuntimeCall = MT.RuntimeCall;
----------------
Is this supposed to return anything else other that `EXIT_FAILURE` or `EXIT_SUCCESS`? If not, why not just use `bool`?

Same for `getValuesInOfflArray()`?


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:919
+  /// Used to get the MemorySSA analysis of a specified function.
+  MemorySSAGetter MSSAGetter;
+
----------------
I think you should be able to use `getAnalysisResultForFunction()` from `OMPInformationCache` since analysis getters are available in Attributor's `InformationCache`. (see Attributor.h)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82719/new/

https://reviews.llvm.org/D82719