[PATCH] D82474: [VectorCombine] try to form vector compare and binop to eliminate scalar ops
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 28 12:56:23 PDT 2020
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM - cheers
================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:89
+/// Determine which, if any, of the inputs should be replaced by a shuffle.
+ExtractElementInst *VectorCombine::getShuffleExtract(
+ ExtractElementInst *Ext0, ExtractElementInst *Ext1,
----------------
Maybe pull this out as a precommit NFC?
================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:523
+/// a vector into vector operations followed by extract.
+bool VectorCombine::foldExtractedCmps(Instruction &I) {
+ // We are looking for a scalar binop of booleans.
----------------
Maybe add an explanation that SLP can't handle this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82474/new/
https://reviews.llvm.org/D82474
More information about the llvm-commits
mailing list