[PATCH] D82641: [AMDGPU] Unify early PS termination blocks

Sat Jun 27 03:56:56 PDT 2020

critson added a comment.

In D82641#2118340 <https://reviews.llvm.org/D82641#2118340>, @cdevadas wrote:

> We are trying to have the kill intrinsic handling early during the instruction selection.
>  I can try to incorporate it all entirely there including the unify block code (if can't find a better place now to have it). 
>  I will also update D77544 <https://reviews.llvm.org/D77544> if this patch goes upstream.

This pass seems to be the logic place for this right now.
Is there any code or ongoing discussion I can refer to for moving kill handling to instruction selection?
I can see a few problems with doing that, but that might just be because I do not know what is planned.

I am fine with this getting blown away when SIInsertSkips is replaced by a better solution, and contributing again to that solution.

I think this patch can be simplified if D77544 <https://reviews.llvm.org/D77544> is submitted first and the order of SIInsertSkips and SIPreEmitPeephole are swapped.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82641/new/

https://reviews.llvm.org/D82641