[PATCH] D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 20:25:51 PDT 2020


Higuoxing accepted this revision.
Higuoxing added a comment.

LGTM with one nit.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/group.test:59
+## This checks that tool will emit an error when trying to remove the symbol
+## table when we have the a group section linked with symtab.
+# RUN: not llvm-objcopy -R .symtab %t %t2 2>&1 | FileCheck %s --check-prefix=ERR -DINPUT=%t
----------------
'have the a group' -> 'have a'


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82274/new/

https://reviews.llvm.org/D82274





More information about the llvm-commits mailing list