[PATCH] D82344: [NewPM] Make PMs and adaptor passes for PMs unskippable

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 18:24:21 PDT 2020


ychen updated this revision to Diff 273875.
ychen added a comment.

- Add test. The test covers all changes except when a user pass is wrapped

in a adaptor pass directly(without nested pass manager). So part of the type
traits in `PassInstrumentation.h` is not tested. The reason is PassInstrumentation
unit tests are relying on `parsePassPipeline` which could not parse adaptor-wrapped user passes.
See D82698 <https://reviews.llvm.org/D82698>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82344/new/

https://reviews.llvm.org/D82344

Files:
  llvm/include/llvm/Analysis/CGSCCPassManager.h
  llvm/include/llvm/IR/PassInstrumentation.h
  llvm/include/llvm/IR/PassManager.h
  llvm/include/llvm/IR/PassManagerInternal.h
  llvm/include/llvm/Transforms/Scalar/LoopPassManager.h
  llvm/unittests/IR/PassBuilderCallbacksTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82344.273875.patch
Type: text/x-patch
Size: 9023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200627/a1ddaf4d/attachment.bin>


More information about the llvm-commits mailing list