[PATCH] D82698: [NewPM] make parsePassPipeline parse adaptor-wrapped user passes

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 18:15:06 PDT 2020


ychen created this revision.
ychen added reviewers: asbirlea, echristo, fedor.sergeev, chandlerc.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

Currently, when parsing text pipeline, different kinds of passes always
introduce nested pass managers. This makes it impossible to test the
adaptor-wrapped user passes from text pipeline interface which is needed
by D82344 <https://reviews.llvm.org/D82344> test cases. This also seems useful in general. See comments above
`parsePassPipeline`.

The syntax would be like mixing passes of different types, but it is
not the same as inferring the correct pass type and then adding the
matching nested pass managers. Strictly speaking, the resulted pipelines
are different.

The test change are for demo and not complete. Want to know reviewers'
opinions first.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82698

Files:
  llvm/include/llvm/Passes/PassBuilder.h
  llvm/lib/Passes/PassBuilder.cpp
  llvm/test/Analysis/GlobalsModRef/aliastest.ll
  llvm/test/Other/cgscc-disconnected-invalidation.ll
  llvm/test/Other/pass-pipeline-parsing.ll
  llvm/test/Transforms/Inline/2007-04-15-InlineEH.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82698.273874.patch
Type: text/x-patch
Size: 11405 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200627/9fc48482/attachment-0001.bin>


More information about the llvm-commits mailing list