[PATCH] D82625: [Attributor][NFC] Replace call site with call base.

Kuter Dinel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 17:48:52 PDT 2020


kuter added a comment.

In D82625#2116406 <https://reviews.llvm.org/D82625#2116406>, @uenoku wrote:

> I think replacing all makes the code hard to understand (because "call base" is just a name of LLVM class)
>  Personally, I prefer maintaining "call site"


Thanks for the feedback. I think It would make sense to call it "call base" since we are making deductions on the LLVM IR.
I think it doesn't make sense to use IRPosition::callsite... when you want to make deductions  about a IR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82625/new/

https://reviews.llvm.org/D82625





More information about the llvm-commits mailing list