[PATCH] D81689: [WebAssembly] New-style command support

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 17:05:20 PDT 2020


sbc100 added inline comments.


================
Comment at: lld/wasm/Writer.cpp:946
+  // define the `__wasm_call_ctors` function.
+  if (!WasmSym::callCtors->isLive() && initFunctions.empty() && !config->isPic)
     return;
----------------
The comment say *or* but the code says "&&".   

Can this part just be reverted?    Since callCtors should not be live unless its needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81689/new/

https://reviews.llvm.org/D81689





More information about the llvm-commits mailing list