[llvm] fb1aa28 - Disable a JSONTest.Integers test with newer MSVCs, PR46470

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 16:58:20 PDT 2020


Author: Nico Weber
Date: 2020-06-26T19:57:52-04:00
New Revision: fb1aa286c1400ad75cd066df6c0233332b3fd9b8

URL: https://github.com/llvm/llvm-project/commit/fb1aa286c1400ad75cd066df6c0233332b3fd9b8
DIFF: https://github.com/llvm/llvm-project/commit/fb1aa286c1400ad75cd066df6c0233332b3fd9b8.diff

LOG: Disable a JSONTest.Integers test with newer MSVCs, PR46470

Added: 
    

Modified: 
    llvm/unittests/Support/JSONTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Support/JSONTest.cpp b/llvm/unittests/Support/JSONTest.cpp
index 0357e2185c32..73fc626af8cb 100644
--- a/llvm/unittests/Support/JSONTest.cpp
+++ b/llvm/unittests/Support/JSONTest.cpp
@@ -324,6 +324,9 @@ TEST(JSONTest, Integers) {
           double{-0x4000000000000000},
       },
 
+      // PR46470,
+      // https://developercommunity.visualstudio.com/content/problem/1093399/incorrect-result-when-printing-6917529027641081856.html
+#if !defined(_MSC_VER) || _MSC_VER < 1926
       {
           "Dynamically exact integer. Stored as double, convertible.",
           double{0x6000000000000000},
@@ -331,6 +334,7 @@ TEST(JSONTest, Integers) {
           int64_t{0x6000000000000000},
           double{0x6000000000000000},
       },
+#endif
 
       {
           "Dynamically integer, >64 bits. Stored as double, not convertible.",


        


More information about the llvm-commits mailing list