[PATCH] D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel

[Mitch Phillips via Phabricator via llvm-commits]

hctim added a comment.

In D82615#2117979 <https://reviews.llvm.org/D82615#2117979>, @aemerson wrote:

> I'm not familiar with these types globals. Do you think there's any issue with the current design that would make it difficult to generate optimal code in future?


No. This codegen should only apply with HWASan (and maybe MTE) in the future -- and the only thing that could need improvement is a slight change to the codegen that would allow the `lo12 add` to be folded into a subsequent `ldr/str`. This patch doesn't do that because of the comment over in `tryFoldAddLowIntoImm(..)`: `// TODO: Need to check GV's offset % size if doing offset folding into globals.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82615/new/

https://reviews.llvm.org/D82615