[PATCH] D82487: [InstCombine] Drop debug loc in TryToSinkInstruction

[Tobias Bosch via Phabricator via llvm-commits]

tbosch added a comment.

Hello Vedant,
this broke our internal llvm bootstrap with errors like this:

  !dbg attachment points at wrong subprogram for function
  !805 = distinct !DISubprogram(name: "terminate", linkageName: "_ZSt9terminatev", scope: !9, file: !798, line: 74, type: !69, scopeLine: 75, flags: DIFlagPrototyped | DIFlagNoReturn | DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !797, retainedNodes: !806)
  void ()* @_ZSt9terminatev
    call void @llvm.dbg.value(metadata %"struct.__cxxabiv1::__cxa_exception"* %11, metadata !2822, metadata !DIExpression(DW_OP_plus_uconst, 96, DW_OP_stack_value)), !dbg !40889
  !40889 = !DILocation(line: 0, scope: !2823)
  !2823 = distinct !DISubprogram(name: "__isOurExceptionClass", linkageName: "_ZN10__cxxabiv121__isOurExceptionClassEPK17_Unwind_Exception", scope: !52, file: !2288, line: 105, type: !2824, scopeLine: 105, flags: DIFlagPrototyped | DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !2287, retainedNodes: !2828)
  !2823 = distinct !DISubprogram(name: "__isOurExceptionClass", linkageName: "_ZN10__cxxabiv121__isOurExceptionClassEPK17_Unwind_Exception", scope: !52, file: !2288, line: 105, type: !2824, scopeLine: 105, flags: DIFlagPrototyped | DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !2287, retainedNodes: !2828)
  conflicting debug info for argument
    call void @llvm.dbg.value(metadata %struct._Unwind_Exception* %160, metadata !2822, metadata !DIExpression()), !dbg !40889
  !42078 = !DILocalVariable(name: "arg", arg: 1, scope: !42076, file: !2499, line: 1198, type: !55)
  !2822 = !DILocalVariable(name: "unwind_exception", arg: 1, scope: !2823, file: !2288, line: 105, type: !2826)
  conflicting debug info for argument
    call void @llvm.dbg.value(metadata %struct._Unwind_Exception* %160, metadata !2831, metadata !DIExpression()), !dbg !42267
  !2822 = !DILocalVariable(name: "unwind_exception", arg: 1, scope: !2823, file: !2288, line: 105, type: !2826)
  !2831 = !DILocalVariable(name: "unwind_exception", arg: 1, scope: !2832, file: !2288, line: 95, type: !2826)
  LLVM ERROR: Broken module found, compilation aborted!

I wonder whether some of the builders that do a bootstrap see this too.

Is this enough for you to know what is going on?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82487/new/

https://reviews.llvm.org/D82487