[PATCH] D82682: LLParser: Accept align(N) as new syntax for parameter attribute

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added a reviewer: jdoerfert.
Herald added subscribers: hiraditya, wdng.
Herald added a project: LLVM.
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

I think this is clearly improving uniformity of the attribute spelling. Thanks. Align was first but is not "special" anymore (in the attribute position).


Every other value parameter attribute uses parentheses, so accept this
as the preferred modern syntax. Updating everything to use the new
syntax is left for a future change.


https://reviews.llvm.org/D82682

Files:
  llvm/docs/LangRef.rst
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/AsmParser/LLParser.h
  llvm/test/Assembler/align-param-attr-error0.ll
  llvm/test/Assembler/align-param-attr-error1.ll
  llvm/test/Assembler/align-param-attr-error2.ll
  llvm/test/Assembler/align-param-attr-format.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82682.273826.patch
Type: text/x-patch
Size: 4358 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200626/042eed56/attachment.bin>