[PATCH] D80220: [VPlan] Add & use VPValue for VPWidenGEPRecipe operands (NFC).

Fri Jun 26 13:08:44 PDT 2020

fhahn added a comment.

In D80220#2095080 <https://reviews.llvm.org/D80220#2095080>, @gilr wrote:

> In D80220#2078460 <https://reviews.llvm.org/D80220#2078460>, @fhahn wrote:
>
> > In D80220#2078222 <https://reviews.llvm.org/D80220#2078222>, @gilr wrote:
> >
> > >
> >
> >
> > We still use GEP->clone() for the case where the GEP is loop invariant. It would probably be best to do that in a follow-on patch. Same for perhaps storing InBounds directly in the recipe as well.
>
>
> Right, clone() should be replaced by generating the GEP from scratch as done in the non-invariant case. Also, now that we have VPOperands it would be better to expose an VPValue::isInvariant() / VPlan::isInvariant(VPValue &) API instead of recording that datum in WidenGEP & WidenSelect recipes, facilitating RAUW. Such API could initially query the underlying IR.
>  Other properties already captured by an underlying value such as inBounds and nsw are probably worth a separate discussion.
>  All these can indeed be follow-ups.

Thanks Gil! I'll prepare follow-up patches in a bit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80220/new/

https://reviews.llvm.org/D80220