[PATCH] D82290: [CodeMoverUtils][WIP] Isolate checks strictly related to the code motion candidate instruction

[Whitney Tsang via Phabricator via llvm-commits]

Whitney added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:323
+      return reportInvalidCandidate(I, NotMovedDebugInfo);
+    if (CI->mayThrow())
+      return reportInvalidCandidate(I, NotMovedThrowCall);
----------------
RithikSharma wrote:
> Whitney wrote:
> > This is covered in line 380.
> Thanks, that check is dependent on DT. I can remove this from here but I'll wait until we decide on keeping DT and PDT as optional argument as then we may end up missing this check. (I'll also look into other such checks if we decide to make DT and PDT optional). 
I see that you are moving a subset of checks from LICM over here, how is this set of checks selected from LICM? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82290/new/

https://reviews.llvm.org/D82290