[PATCH] D82487: [InstCombine] Drop debug loc in TryToSinkInstruction

[Vedant Kumar via Phabricator via llvm-commits]

vsk marked an inline comment as done.
vsk added a comment.

Thanks!



================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3358
 
+  // Drop the debug loc. This prevents single-stepping from going backwards.
+  I->setDebugLoc(DebugLoc());
----------------
aprantl wrote:
> Should we add anchors to the rst document and refer to the rule by anchor in the comment?
We tend not to embed links pointing within .rst docs in llvm/lib (I think with good reason, as the source code and the docs can easily get out of sync), but I think it's a good idea to add a pointer to the doc. I'll do this before landing the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82487/new/

https://reviews.llvm.org/D82487