[PATCH] D82454: [ADT] Add Bitfield utilities - design #3
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 26 12:02:27 PDT 2020
aprantl added inline comments.
================
Comment at: llvm/include/llvm/ADT/Bitfields.h:15
+/// ----------------------
+/// C++ bitfields do not offer control over the bit layout nor consitent
+/// behavior when it comes to out of range values.
----------------
`consistent`
================
Comment at: llvm/include/llvm/ADT/Bitfields.h:93
+
+// A struct defining useful bit patterns for n-bits integer types.
+template <typename T, unsigned Bits> struct BitPatterns {
----------------
Could you please use `///` doxygen comments for (pretty much) all comments in this file?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82454/new/
https://reviews.llvm.org/D82454
More information about the llvm-commits
mailing list