[PATCH] D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: clang/lib/Headers/altivec.h:16835
+/* vec_sldbi */
+
+#define vec_sldb(__a, __b, __c)                                                \
----------------
Please align the `\` at the 80 char line limit like other functions.


================
Comment at: llvm/test/MC/PowerPC/p10.s:36
             vclrrb 1, 4, 3
+# CHECK-BE: vsldbi 2, 3, 4, 5               # encoding: [0x10,0x43,0x21,0x56]
+# CHECK-LE: vsldbi 2, 3, 4, 5               # encoding: [0x56,0x21,0x43,0x10]
----------------
Can you please adjust the indenting of the `# encoding` to be aligned with other lines?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82440/new/

https://reviews.llvm.org/D82440