[PATCH] D82193: [OpenMPOpt] ICV macro definitions

Fri Jun 26 11:29:46 PDT 2020

daltenty added inline comments.

================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:327
+__ICV_DATA_ENV(active_levels, NONE, ZERO)
+__ICV_DATA_ENV(cancel, OMP_CANCELLATION, FALSE)
+__ICV_DATA_ENV(__last, last, LAST)
----------------
fhahn wrote:
> sstefan1 wrote:
> > jdoerfert wrote:
> > > daltenty wrote:
> > > > sstefan1 wrote:
> > > > > fhahn wrote:
> > > > > > Is it possible to use a different name than `FALSE` here, because it will fail to compile if the system headers contain a `FALSE` define? Maybe something like `ICV_FALSE` to avoid conflicts.
> > > > > Sure! I hope we will move away from macro magic soon anyway.
> > > > > 
> > > > > @jdoerfert sounds good?
> > > > We currently have exactly such a build break from this change on AIX due to the system headers defining `FALSE`
> > > `ICV_..` for all of them seems sensible. Thanks for catching this!
> > Sorry about that. Should be fixed with rG951e43f357ec3ee0ffc570aea9cbf19871696c42
> great thanks!
Thanks, this seems to have resolved our build issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82193/new/

https://reviews.llvm.org/D82193