[PATCH] D82481: [XCOFF][AIX] Give symbol an internal name when desired symbol name contains invalid character(s)

[Xiangling Liao via Phabricator via llvm-commits]

Xiangling_L added inline comments.


================
Comment at: llvm/lib/MC/MCContext.cpp:311
+  // Let's replace with something valid, but save the original name so that
+  // we could still have use the original name in the symbol table.
+  SmallString<128> InvalidName(OriginalName);
----------------
`s/have use/have` or `s/have use/use`?


================
Comment at: llvm/lib/MC/MCContext.cpp:326
+
+  unsigned &NextUniqueID = NextID[ValidName];
+  if (NextUniqueID) {
----------------
I think some comments here explaining the way we handle the name conflict may lead to entry point and function descriptor symbols rename mismatch may help.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82481/new/

https://reviews.llvm.org/D82481