[PATCH] D81850: [AArch64][SVE] NFC: Choose consistent naming for predicated SDAG nodes

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 09:50:09 PDT 2020


sdesmalen updated this revision to Diff 273756.
sdesmalen added a comment.

Renamed nodes as follows:

  // For predicated nodes where the result is a vector, the operation is
  // controlled by a governing predicate and the inactive lanes are explicitly
  // defined with a value, please stick the following naming convention:
  //    _MERGE_OP0
  //    _MERGE_OP1
  //         :
  //    _MERGE_OP<n>     The result value is a vector with false lanes equal to
  //                     source operand OP<n>.
  //
  //    _MERGE_ZERO      The result value is a vector with false lanes actively
  //                     zeroed.
  //
  // For other cases where no explicit action is needed to set the inactive lanes,
  // or when the result is not a vector and it is needed or helpful to
  // distinguish a node from similar unpredicated nodes, use:
  //
  //    _PRED


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81850/new/

https://reviews.llvm.org/D81850

Files:
  llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
  llvm/lib/Target/AArch64/SVEInstrFormats.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81850.273756.patch
Type: text/x-patch
Size: 132424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200626/e5acf085/attachment-0001.bin>


More information about the llvm-commits mailing list