[PATCH] D82483: [SVE] Code generation for fixed length vector adds.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 09:50:10 PDT 2020


sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14797
+
+static SDValue getPredicateForVector(SelectionDAG &DAG, SDLoc &DL, EVT VT) {
+  if (VT.isFixedLengthVector())
----------------
nit: is `getAllTruePredicate` not a better name given the value this function returns? (similar for `getAllTruePredicateFor(Scalable|FixedLength)Vector`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82483/new/

https://reviews.llvm.org/D82483





More information about the llvm-commits mailing list