[PATCH] D82211: [SVE] Remove calls to VectorType::getNumElements from ExecutionEngine

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 07:04:02 PDT 2020


sdesmalen added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/ExecutionEngine.cpp:1105
   case Type::ScalableVectorTyID: {
-    auto *VT = cast<VectorType>(Ty);
+    // FIXME: this needs to handle scalable vectors correctly
+    auto *VT = cast<FixedVectorType>(Ty);
----------------
This needs a similar:
```report_fatal_error(
            "Scalable vector support not yet implemented in ExecutionEngine");```

Maybe you can also add the FIXME about scalable-vectors to the top-level comment of this file, as I suspect we want to add support for scalable vectors to this pass at some point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82211/new/

https://reviews.llvm.org/D82211





More information about the llvm-commits mailing list