[PATCH] D82651: [GlobalISel][InlineAsm] Add support for matching input constraints

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp:235
 
+static unsigned getNumOpRegs(MachineInstr *I, unsigned OpIdx) {
+  unsigned Flag = I->getOperand(OpIdx).getImm();
----------------
const reference


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-inline-asm.ll:251
+  ; CHECK:   S_SETPC_B64_return [[COPY4]], implicit $vgpr0
+  %1 = and i32 %a, 1
+  %2 = call i32 asm sideeffect "; ", "=v,0"(i32 %1)
----------------
Should use named values in tests


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-inline-asm.ll:293
+}
+
 !0 = !{i32 70}
----------------
Can you add some cases that use different and mixed register classes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82651/new/

https://reviews.llvm.org/D82651