[PATCH] D82557: [MSP430][NFC] Remove redundant condition
Balogh, Ádám via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 26 05:56:59 PDT 2020
baloghadamsoftware marked 2 inline comments as done.
baloghadamsoftware added inline comments.
================
Comment at: llvm/lib/Target/MSP430/MSP430FrameLowering.cpp:95
// mergeSPUpdatesDown(MBB, MBBI, &NumBytes);
+ //if (NumBytes) {
----------------
asl wrote:
> baloghadamsoftware wrote:
> > asl wrote:
> > > Ditto
> > Originally, I commented out this, because of the commented-out line above, because they belong together. Now I removed it too.
> Still, there is some commented-out code. And you left obsolete comments which are misleading after removing the code. Will you please remove them while you're there?
Sorry, I overlooked that line.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82557/new/
https://reviews.llvm.org/D82557
More information about the llvm-commits
mailing list