[PATCH] D82643: [AMDGPU] Remove -amdgpu-verify-regbanks-reassign

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 04:50:54 PDT 2020


foad added a comment.

Alternative solution #1: I //think// analyzeInst always returns the exact number of stalls or an overestimate, never an underestimate, so I could keep verifyCycles and change it to check the inequality `StallCycles + CyclesSaved <= OriginalCycles`.

Alternative solution #2: I could change tryReassign to scavenge a register from each bank before calling computeStallCycles, so we know exactly which register we're going to replace Reg with. But that might be expensive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82643/new/

https://reviews.llvm.org/D82643





More information about the llvm-commits mailing list