[PATCH] D82557: [MSP430][NFC] Remove redundant condition

Balogh, Ádám via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 04:18:38 PDT 2020


baloghadamsoftware marked 4 inline comments as done.
baloghadamsoftware added inline comments.


================
Comment at: llvm/lib/Target/MSP430/MSP430FrameLowering.cpp:91
     // the two.
     //NumBytes -= mergeSPUpdates(MBB, MBBI, true);
     // If there is an ADD16ri or SUB16ri of SP immediately after this
----------------
asl wrote:
> Please do not add commented-out code. Thanks!
This was already in the code, I did not change it. Now I removed it.


================
Comment at: llvm/lib/Target/MSP430/MSP430FrameLowering.cpp:95
     // mergeSPUpdatesDown(MBB, MBBI, &NumBytes);
+    //if (NumBytes) {
 
----------------
asl wrote:
> Ditto
Originally, I commented out this, because of the commented-out line above, because they belong together. Now I removed it too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82557/new/

https://reviews.llvm.org/D82557





More information about the llvm-commits mailing list